Closed
Bug 1919345
Opened 5 months ago
Closed 16 days ago
Add profiler markers for Glean::Ping
Categories
(Toolkit :: Telemetry, task)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
136 Branch
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: aabh, Assigned: aabh)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•4 months ago
|
||
I'm not sure we can actually provide useful markers for this. Yes, we can get useful information in the new method for Ping, but as the arguments are then used to create the private/opaque glean-internal ping type, we cannot actually report them when we submit the ping itself.
|
||
Comment 2•4 months ago
|
||
I think knowing the name and reason on submit is useful enough to be worth the cost of storing an owned string of the ping's name on creation so we can mark a later submission.
The debug-only submit_ping_by_name should also be marked.
|
|
Assignee | |
Comment 3•3 months ago
|
||
Ah, good info, thanks Chris. I'll go ahead and add some markers for this then!
|
|
Assignee | |
Comment 4•2 months ago
|
||
Pushed by abrouwersharries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d06afa53b9a
Add profiler markers for Glean::Ping r=chutten,florian
|
||
Comment 6•16 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•