1919611 - Windows HCM mode no longer matches @media (forced-colors) in the browser chrome

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mark Striemer [:mstriemer]]

This appears to be a regression from bug 1878919, but toolbar buttons no longer have an outline in Windows HCM with the system theme installed, and it appears to be because window.matchMedia("(forced-colors").matches is false.

Running a mozregression pointed to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e00a1998c3ae8382094a2ed894957d55948ab750&tochange=2c735de75ad99524f003059a114084a5bfca2d90

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1878919

:emilio, since you are the author of the regressor, bug 1878919, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1878919

:emilio, since you are the author of the regressor, bug 1878919, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I'm assuming you just mis-copied the regressing bug?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1919611 - Fix #ifdef for windows. r=nchevobbe,mstriemer,#layout

And add a test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab2530c2962f
Fix #ifdef for windows. r=nchevobbe,dshin

Comment 6

[Mark Striemer [:mstriemer]]

Yes, thank you for the quick fix, Emilio!

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ab2530c2962f