1919706 - FullscreenFeature does not immediately update it's isFullScreen property

Status: RESOLVED FIXED

(Fenix :: Media, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Seen while investigating bug 1918757.
The isFullScreen of FullscreenFeature property which should closely match the fullScreen property of ContentState does not immediately do this but only after informing through callback that the fullscreen status has changed.
If in that moment other app features query isFullScreen they would get the old value, not the new one.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1919706 - Update FullScreenFeature to more eagerly update it's `isFullscreen` property r=#android-reviewers

Previously if evaluating isFullscreen inside FullScreenFeature's fullScreenChanged callback
we would get the old value and not the current status of the tab.
This change fixes that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/441d58bc31f5
Update FullScreenFeature to more eagerly update it's `isFullscreen` property r=android-reviewers,Roger

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/441d58bc31f5