1919709 - ESLint builders are using Node 16 rather than Node 18

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Mark Banner (:standard8)]

I've been working on various patches to get us updated to ESLint v9 which uses a new configuration format that's simpler to understand and more deterministic. As part of this, we need to update our the ESLint plugins which themselves have been updated to work with v9.

The Jest module has started using structuredClone which is new in Node 18. I also want to be able to use that in some of the ESLint code.

Whilst bug 1875239 upgraded Node for most test builders, it looks like it didn't do the source test builders - they use install-node.sh which currently installs node 16

Comment 1

[Mike Hommey [:glandium]]

At some point, we should switch them to using the toolchain node rather than installing it in the docker image.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1919709 - Move ESLint CI runners to use node from the toolchains rather than a separate install. r?glandium!

This changes the lint docker image to not install node, and updates the consumers to use the node toolchain where appropraite.

As devtools requires Yarn their builders are, at least tempoarily, switched to the ubunutu1804-test Docker images which are still using the separate install process for node.

This also adds prettier as an installed package for the devtools debugger code - some of the tests actually use it, and they were only passing because it was being side-installed by the builder using the ESLint node_modules bundles.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a63dcdbdff7b
Move ESLint CI runners to use node from the toolchains rather than a separate install. r=glandium

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a63dcdbdff7b