1919734 - Unexpected word selection for double click URL while addressbar in edit mode

Status: ASSIGNED

(Firefox :: Address Bar, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: double-click-edit-mode.mp4

Found in

• 132.0a1 (2024-09-18)

Affected versions

• 132.0a1 (2024-09-18)

Tested platforms

• Affected platforms: Windows 10, Mac 14, Ubuntu 24

Preconditions

• browser.urlbar.scotchBonnet.enableOverride set on TRUE
• browser.urlbar.trimURLs set on TRUE (default nightly)
• browser.urlbar.trimHttps set on TRUE (default nightly)
• browser.urlbar.untrimOnUserInteraction.featureGate set on TRUE (default nightly)
• dom.security.https_first_schemeless set on TRUE (default nightly)
• Dom.security.https_first set on FALSE

Steps to reproduce

1. Load google.com.
2. Click once in the address bar to enter edit mode (protocol is not unfurled)
3. Hover the mouse over an o from the google word.
4. Double click.

Expected result

• google is selected.

Actual result

• www is selected

Regression range

• N/A

Comment 1

[Marco Bonardo [:mak]]

Ok, this is a case I didn't consider, as it's a lot more common to double click before selecting and that's what we fixed.
It may be problematic to fix, because we can't know if the user is going to click or double click until 1s is passed from the first click. I can intermittently also reproduce it in Chrome, though it works fine most of the times.
Let me think about it.

Comment 3

[Vincent Lefevre]

Similarly:

1. Open a URL like this bugzilla one.
2. Double click on the first word (here, "bugzilla"), but do not release the mouse button.
3. Extend the selection to the full domain (here, "bugzilla.mozilla.org").
4. Release the mouse button.

Observed behavior: the "https://" is also selected.

Same issue if I just select "bugzilla.mozilla.org" or more on the right, without a double-click.

Note that this does not occur if I do not select the full host name, e.g. if I just select "bugzilla.mozilla" or "bugzilla.mozilla.or" instead of "bugzilla.mozilla.org".

Comment 4

[Marco Bonardo [:mak]]

(In reply to Vincent Lefevre from comment #3)

Similarly:

1. Open a URL like this bugzilla one.
2. Double click on the first word (here, "bugzilla"), but do not release the mouse button.
3. Extend the selection to the full domain (here, "bugzilla.mozilla.org").
4. Release the mouse button.

Observed behavior: the "https://" is also selected.

That's on purpose. you are selecting the domain or a partial url including the domain, we trimmed the protocol, so we just add it back since the selection is from the beginning.

Comment 5

[Vincent Lefevre]

(In reply to Marco Bonardo [:mak] from comment #4)

That's on purpose. you are selecting the domain or a partial url including the domain, we trimmed the protocol, so we just add it back since the selection is from the beginning.

This is bad as this prevents one from just selecting the host name.