Closed Bug 1919867 Opened 2 months ago Closed 2 months ago

Configure/support sidebar + chatbot onboarding screens

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

Bug 1919863 is intended to focus on strings especially because they need to land before 132 string freeze, so this bug is more of making sure we can configure the screens correctly:

Out of scope for 132 is the "New!" badging and presumably other styling not supported by the welcome bundle (I'm thinking the "What's new in Firefox" small header above "Vertical tabs are here" primary header). There are planned followup fixes with bug 1919873 to better match styling.

I previously set up a preview experiment https://experimenter.services.mozilla.com/nimbus/sidebar-vertical-tabs-layout-and-new-tools to test out bug 1895932 for setting sidebar prefs, and this is before bug 1910633 adding the single select picker that we'll actually want to use for vertical vs horizontal and that same patch is also adding SpecialMessageActions to allow SET_PREF of sidebar.verticalTabs.

As mentioned in bug 1919863, we might want to land about:welcome screen configuration in-tree to support macOS new user onboarding, and we can set targeting to check for sidebar.revamp for conditionally showing a screen and potentially also checking sidebar.verticalTabs (set by nimbus) to determine which default value is selected. We could do similar in-tree configuration for existing user spotlight but not as necessary compared to new user.

We will need a new SpecialMessageActions to open the sidebar where potentially we pass in a pane to open, e.g., viewGenaiChatSidebar. The current placeholder preview experiment I have a hardcoded OPEN_CHATBOT:

{
  "id": "existing_sidebar_genai",
  "template": "spotlight",
  "content": {
    "id": "a",
    "template": "multistage",
    "backdrop": "transparent",
    "transitions": true,
    "screens": [
      {
        "id": "vertical",
        "content": {
          "position": "split",
          "reverse_split": true,
          "title": "vertical tabs have arrived",
          "secondary_button": {
            "has_arrow_icon": true,
            "label": "next",
            "action": {
              "navigate": true
            }
          }
        }
      },
      {
        "id": "ai",
        "content": {
          "position": "split",
          "reverse_split": true,
          "title": "experimenting with ai?",
          "primary_button": {
            "label": "set up chatbot",
            "action": {
              "navigate": true,
              "type": "OPEN_CHATBOT"
            }
          },
          "secondary_button": {
            "has_arrow_icon": true,
            "label": "start browsing",
            "action": {
              "navigate": true
            }
          }
        }
      }
    ]
  },
  "frequency": {
    "lifetime": 1
  },
  "trigger": {
    "id": "defaultBrowserCheck"
  },
  "targeting": "true"
}
See Also: → 1919873

Sounds like we'll run the experiments excluding RTL and windows only for new user, so we can probably skip landing screens in tree. There will still need to at least be a special message action to open the sidebar.

Add OPEN_SIDEBAR special message action.

Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #9426330 - Attachment description: Bug 1919867 - Configure/support sidebar + chatbot onboarding screens → Bug 1919867 - Configure/support sidebar + chatbot onboarding screens r=#omc-reviewers!
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2afbed162210 Configure/support sidebar + chatbot onboarding screens r=omc-reviewers,aminomancer
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: