1919951 - [wpt-sync] Sync PR 48216 - [wpt] Fix masked failure in `display-mode.https.html`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48216 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48216
Details from upstream follow.

Jonathan Lee <[e-mail]> wrote:

[wpt] Fix masked failure in display-mode.https.html

a. assert_true() checks for strict equality with true 0, so coerce
the MediaQueryList accordingly.
b. Failure (a) was not correctly attributed to the test because
step_func_done() expects sync functions that can throw 1. Passing
an async function will immediately mark the test as a success, but
the returned promise that eventually rejects isn't handled, causing
a harness error 2. The async_test() can be expressed more
naturally as a promise_test().

Bug: 41496375
Change-Id: I894678b014ffdbc69e3e8b4e766eccefc1a67043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868839
Commit-Queue: Jonathan Lee \<[e-mail]>
Reviewed-by: Fr \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1356524}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7569172fd75d72aeb295000a0a1d2e46b54cf92

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /document-picture-in-picture/display-mode.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • Test picture-in-picture display mode: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /document-picture-in-picture/display-mode.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22a0177a7756
[wpt PR 48216] - [wpt] Fix masked failure in `display-mode.https.html`, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/22a0177a7756