1919953 - [wpt-sync] Sync PR 48217 - [wpt] Detect miscategorized crashtests

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48217 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48217
Details from upstream follow.

Jonathan Lee <[e-mail]> wrote:

[wpt] Detect miscategorized crashtests

https://web-platform-tests.org/writing-tests/crashtest.html says:

Crashtests are identified by the string -crash in the filename
immediately before the extension, or by being in a directory called
crashtests.

In particular:

• css/css-foo/bar-crash-001.html is not a crash test

This CL fixes the names for files intended to run as crash tests 0.
Currently, these tests don't have any coverage 1 because wpt manifest doesn't detect and write them to MANIFEST.json.

Bug: None
Change-Id: I4c2100d9d43b91f4b6a6697a01e0e1754add621f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868914
Reviewed-by: Morten Stenshorne \<[e-mail]>
Commit-Queue: Jonathan Lee \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1356525}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 48217 applied with additional changes from upstream: a8c39a102fc211f67dfc4dec645f7cd37538b998

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=de03e2d8aaac49c23bbff028b94ac72d5aace3c8

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests

Status Summary

Firefox

PASS : 16

Chrome

PASS : 15
CRASH: 1

Safari

PASS : 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4128ec9ac829
[wpt PR 48217] - [wpt] Detect miscategorized crashtests, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4128ec9ac829