Closed Bug 1919963 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 48228 - Remove ::select-fallback-button

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox132 fixed)

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48228 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48228
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Remove ::select-fallback-button

This patch removes customizable \<select>'s fallback \<button> element in
the UA shadowroot by replacing it with the same "InnerElement" \<div>
which is used for appearance:auto.

Several supporting changes were made in order to implement this:

  • Also remove ::select-fallback-button-text
  • Add -internal-appearance-auto-base-select() support for the following
    properties:
    • min-block-size
    • min-inline-size
    • padding-block-start
    • padding-block-end
    • padding-inline-start
    • padding-inline-end
    • content in select::after
  • Make \<select> focusable again when there is no child \<button> element
  • Remove dependency on popover triggering code in HTMLFormControlElement
    now that we aren't always opening the popover with a \<button>

This is in response to feedback here:
https://github.com/w3c/csswg-drafts/issues/10717

This also addresses additional feedback I received privately that author
styles applied to the select element itself weren't applying to the
in-page portion of the element.

Change-Id: I0a833b370babe9a8ab937822a3578d839510a8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786670
Reviewed-by: David Baron \<dbaron@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1356701}

PR 48228 applied with additional changes from upstream: a05aea515ae7ed866237c0318fa6c05a9d31eeeb
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/565c005e9f4b [wpt PR 48228] - Remove ::select-fallback-button, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.