Closed Bug 1919992 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 48238 - [wptrunner] Generalize WebDriver-based print-reftest implementation

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox132 fixed)

Status:
RESOLVED FIXED
Milestone:
132 Branch
Tracking Flags:
Tracking Status
firefox132 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48238 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48238
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

[wptrunner] Generalize WebDriver-based print-reftest implementation

Most of the implementation is lifted verbatim from an existing chromedriver one, except the nonstandard CDP call in render_as_pdf() is replaced by an equivalent one to WebDriver's "print page".

shrinkToFit is actually a WebDriver parameter, not a CDP one, so this PR also fixes some incorrectly scaled screenshots.

Fixes #48237

PR 48238 applied with additional changes from upstream: 384f5d9f4d9dccecb3374990ffdc9b3e181d5ff5
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5fd37a27c1db [wpt PR 48238] - [wptrunner] Generalize WebDriver-based print-reftest implementation, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/5fd37a27c1db

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox132: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.