1920061 - Frequent switching between normal video and pip resulted in the video image no longer appearing in the pip window, although the audio would play.

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Alice0775 White]

Steps to reproduce:

1. Open youtube video and playback
   e.g. http://www.youtube.com/watch?v=BH0BNbwqNK8
2. Click pip toggle button in location bar Ctrl+Shift+]
3. Repeat Step 2 about 10 times at approximately 0.5-1.0 second intervals.

Actual results:
Pip window becomes black, no video image. But audio is playing.
When this occurs, video image stops in the browser after turning off the pip window
Profiler log: https://share.firefox.dev/3XQE0fi

Expected results:
Video images should also play normally in pip or main browser

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5886d166601b6c778a05c9f7028d4bdafd7b829c&tochange=d52c1ab80f0123ce77837924151f04efcab45623

Comment 1

[Alice0775 White]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1899450

:sotaro, since you are the author of the regressor, bug 1899450, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Sotaro Ikeda [:sotaro]]

I take a look.

Comment 4

[Sotaro Ikeda [:sotaro]]

It seemed that the problem seemed to happen with any GPU that enables zero copy video with hardware video decoding. And the problem was addressed by pause and resume the video.

Comment 5

[Sotaro Ikeda [:sotaro]]

On AMD GPUs, Bug 1899450 caused the regression. For Intel GPUs and NVIDIA GPUs, the problem already existed.

Comment 6

[Sotaro Ikeda [:sotaro]]

It seems necessary to clear all images of secondary ImageContainer, when it is removed from VideoSink.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1920061 - Clear all images of secondary ImageContainer, when it is removed from VideoSink

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57d00570b136
Clear all images of secondary ImageContainer, when it is removed from VideoSink r=media-playback-reviewers,karlt

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1899450

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/57d00570b136

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Sotaro Ikeda [:sotaro]]

Alice0775 White, can you check if the problem is addressed with latest nightly?

Comment 13

[Alice0775 White]

I managed to reproduce the issue on Nightly133.0a1(20240930215150) Windows11.
And I verified the fix on latest Nightly133.0a1(20241003094710) Windows11.

Comment 14

[Sotaro Ikeda [:sotaro]]

Great! Thank you.

Comment 15

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9427671 [details]
Bug 1920061 - Clear all images of secondary ImageContainer, when it is removed from VideoSink

Beta/Release Uplift Approval Request

• User impact if declined: zero video frame happen with the STR of Bug 1920061 comment 0 when zero video frame copy is enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change just clear posted video frames from obsolete pip VideoSink.
• String changes made/needed:
• Is Android affected?: Yes

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9427671 [details]
Bug 1920061 - Clear all images of secondary ImageContainer, when it is removed from VideoSink

Approved for 132.0b4.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/240b91f24d7c

Comment 18

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected nightly from 2024-09-20, on Win 10.
Verified as fixed on Firefox 132.0b4 (20241007091632) using Win 10 and Win 11.