1920167 - Add missing .length property in looping logic of 'extractDomainsFromDocument' method

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[kernp25]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0

Expected results:

This should be if (!elements.length) {?

Comment 1

[Rob Wu [:robwu]]

Thanks for your report. This looks like a valid bug and easy to fix.

The code was introduced in bug 1846357. Because of the bug, all logic below is skipped: https://searchfox.org/mozilla-central/rev/43450868e9f3e26da88a02837e5a43c93728ea95/browser/actors/SearchSERPTelemetryChild.sys.mjs#1158-1188

Stephanie, as the author of the code, can you take a look? Fixing this is trivial, but you may also want to consider the impact of the issue and/or request uplifts if needed.

Comment 2

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1920167 - Add missing .length property in looping logic of 'extractDomainsFromDocument' method. r?jteow!

Comment 3

[Stephanie Cunnane [:scunnane]]

Wow kernp25, thanks for finding this.

I'm not going to request an uplift since the missing property isn't actually causing an issue in the existing code. (The methods that call extractDomainsFromDocument already skip over empty arrays.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2913dfac59e7
Add missing .length property in looping logic of 'extractDomainsFromDocument' method. r=jteow

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2913dfac59e7