1920314 - length property missing in /browser/extensions/pictureinpicture/video-wrappers/hotstar.js#15

Status: ASSIGNED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[kernp25]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0

Expected results:

It seems the length property is missing here?

Comment 1

[kernp25]

Also, this should just be callback();.

Comment 2

[kernp25]

Attachment: Bug 1920315 - Fix subtitle support for dailymotion.com. r=#pip-reviewers

Comment 3

[Phabricator Automation]

Comment on attachment 9426370 [details]
Bug 1920315 - Fix subtitle support for dailymotion.com. r=#pip-reviewers

Revision D223069 was moved to bug 1920315. Setting attachment 9426370 [details] to obsolete.

Comment 4

[kpatenio]

Unlike Bug 1920309, I'm keeping this ticket as a defect.

kernp25 - I know your first patch was intended for dailymotion, but are you working on a patch for hotstar too? If not, I will unassign you from the bug.

(In reply to kernp25 from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0

Expected results:

It seems the length property is missing here?

Good catch. We probably want to check for the NodeList's length here. In addition to this, there's no need for having container? since the query is run if container is not falsey in the first place.

(In reply to kernp25 from comment #1)

Also, this should just be callback();.

I think we can simplify to callback(), yes, since we're not using a loop to find the node with text content.

Comment 5

[kernp25]

Attachment: Bug 1920314 - Update video wrappers. r?#pip-reviewers,niklas,kpatenio