1920515 - Flipping enableUpdatedAddImage pref also makes "Create alt text automatically" toggle visible.

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Ania]

Attachment: enableUpdatedAddImage

Steps to reproduce the problem:

1. Flip enableUpdatedAddImage to true
2. Open a PDF file in Firefox, add image

What is the expected behavior?
New image editor opens, with no Create alt text automatically toggle displayed.

Actual result (please see screenshot)
Create alt text automatically toggle is displayed, even though the functionality is unavailable to a user.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Don't show the ml toggle button when the ml is disabled (bug 1920515) (#18779)

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1920515 - Correctly hide the ml toggle button in the alt-text dialog in pdf.js when ml is disabled

Comment 3

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Low
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See comment#1
• Risk associated with taking this patch: Low
• Explanation of risk level: one-liner patch behind a pref because it's for an experiment
• String changes made/needed: no
• Is Android affected?: no

Comment 4

[Dianna Smith [:diannaS]]

:calixte is there a deadline on the experiment? can this go in a dot release (aka october 15)? We already built RC and not sure if we will have an RC2 yet.

Comment 5

[Calixte Denizet (:calixte)]

:calixte is there a deadline on the experiment? can this go in a dot release (aka october 15)? We already built RC and not sure if we will have an RC2 yet.

I don't know, but :Ania does.

Comment 6

[Rares Doghi, Desktop QA]

Hi @Calixte Is this in our latest Nigthly build ? did it land in mozilla-central ? I flipped enableUpdatedAddImage to true and added an image to a pdf and I still see the Create Alt text automatically.

Comment 7

[Calixte Denizet (:calixte)]

According to https://hg.mozilla.org/mozilla-central/rev/6248bf2388ba, it should be in the lastest Nightly.
I just checked with the latest and it wfm.

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly Build Id 20240925090641

Comment 9

[Ania]

Hi folks,
Calixte, thank you so much for prioritizing the fix.
This can wait until the dot release, I don't want to create an additional stress point for everyone by trying to get into the RC.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Calixte Denizet (:calixte)]

There's already an uplift request for 131.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/9b6d74495e3a

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release 131.0.3