192054 - Bugzilla dependencies upgrade messages in wrong order

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Gervase Markham [:gerv]]

From mail with justdave:
> Did someone change the order of the array?  I remember hassling dkl about
> that when we changed to using a hash for the dependency list because it
> listed the dependencies out of order.  If it's doing that now, someone's
> broken it again since then, and it should by all means be fixed.

As far as I can see, we use an array to store the dependency list, but a hash to
collect the names of the ones we are missing. So, the missing modules still come
out in hash order (i.e. any order you like.) This also needs to be a list, to
preserve the ordering.

Gerv

Comment 1

[Max Kanat-Alexander]

It turns out that having this fixed will make bug 262269 easier, so I'm going to fix it for 3.2.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, this does it. Note that this means that optional modules are now printed out in the order that they're listed in the constant, so please keep related modules together, and keep them in the proper dependency order.

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.32; previous revision: 1.31
done