Bugzilla dependencies upgrade messages in wrong order

RESOLVED FIXED in Bugzilla 3.2

Status

()

--
minor
RESOLVED FIXED
16 years ago
12 years ago

People

(Reporter: gerv, Assigned: mkanat)

Tracking

2.17.3
Bugzilla 3.2
Bug Flags:
approval +

Details

Attachments

(1 attachment)

From mail with justdave:
> Did someone change the order of the array?  I remember hassling dkl about
> that when we changed to using a hash for the dependency list because it
> listed the dependencies out of order.  If it's doing that now, someone's
> broken it again since then, and it should by all means be fixed.

As far as I can see, we use an array to store the dependency list, but a hash to
collect the names of the ones we are missing. So, the missing modules still come
out in hash order (i.e. any order you like.) This also needs to be a list, to
preserve the ordering.

Gerv

Updated

16 years ago
Component: Administration → Installation & Upgrading

Updated

13 years ago
QA Contact: mattyt-bugzilla → default-qa
(Assignee)

Updated

13 years ago
Assignee: dkl → installation
Severity: normal → minor
(Assignee)

Comment 1

12 years ago
It turns out that having this fixed will make bug 262269 easier, so I'm going to fix it for 3.2.
Assignee: installation → mkanat
Blocks: 262269
Target Milestone: --- → Bugzilla 3.2
(Assignee)

Comment 2

12 years ago
Created attachment 259139 [details] [diff] [review]
v1

Okay, this does it. Note that this means that optional modules are now printed out in the order that they're listed in the constant, so please keep related modules together, and keep them in the proper dependency order.
Attachment #259139 - Flags: review+
(Assignee)

Comment 3

12 years ago
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.32; previous revision: 1.31
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: approval+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.