1920563 - Clean up / rename / relocate icons reused by chatbot

Status: RESOLVED FIXED

(Firefox :: Theme, task, P2)

Description

[Ed Lee :Mardak]

Chatbot onboarding bug 1914977 reused some icons that were originally for other purposes:

• analyze using password's resource://gre-resources/password.svg
• switch using places' chrome://browser/skin/import-export.svg
• price using shopping's chrome://browser/content/shopping/assets/price.svg

These probably can be named something more generic and located in shared themes in browser or toolkit as appropriate

Comment 1

[Dão Gottwald [:dao]]

Hey Ed, were you planning on / would you be able to take this after bug 1914977?

Comment 2

[Ed Lee :Mardak]

sure after 132

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1920563 - Clean up / rename / relocate import-export.svg icon reused by chatbot

Move icon to toolkit and remove translations' duplicate

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1920563 - Clean up / rename / relocate password{-hide}.svg icons reused by chatbot

Move icons to toolkit and remove aboutlogins' duplicates

Depends on D237982

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1920563 - Clean up / rename / relocate price.svg icon reused by chatbot

Move icon from components to themes

Depends on D237983

Comment 6

[Fred Chasen [:fchasen]]

:Mardak Just a heads up that price.svg is going to be removed in 140, so will need to copy that to a new location soon.

Comment 7

[Ed Lee :Mardak]

ok i'll ping again on the patch and if not, i'll try getting price.svg moved first

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a0c66d2e2dd
Clean up / rename / relocate import-export.svg icon reused by chatbot r=desktop-theme-reviewers,places-reviewers,translations-reviewers,firefox-ai-ml-reviewers,dao,gregtatum,ngrato
https://hg.mozilla.org/integration/autoland/rev/40d0aba7b3d1
Clean up / rename / relocate password{-hide}.svg icons reused by chatbot r=mtigley,desktop-theme-reviewers,credential-management-reviewers,firefox-ai-ml-reviewers,dao,ngrato
https://hg.mozilla.org/integration/autoland/rev/8bfecb47de98
Clean up / rename / relocate price.svg icon reused by chatbot r=desktop-theme-reviewers,firefox-ai-ml-reviewers,dao,ngrato

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1a0c66d2e2dd
https://hg.mozilla.org/mozilla-central/rev/40d0aba7b3d1
https://hg.mozilla.org/mozilla-central/rev/8bfecb47de98