Closed
Bug 1920565
Opened 4 months ago
Closed 2 months ago
Tidy up channels code in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file, 1 obsolete file)
|
5.33 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
This bug deals with some tidy up in the cZ channels code:
- msg.cd.wait.list does not seem to be used anywhere
- MSG_CHANNEL_OPENED is not used or defined anywhere
- XUL element loadContainer is not used in JS so no point caching it
- platform specific CSS can be done in a different way, so do it that way to remove code
- remove fallback of using type="timed"
- fix typo for selectedIndex for bottomPanel deck
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: unused string removal
Attachment #9426607 -
Flags: review?(frgrahl)
Attachment #9426607 -
Flags: approval-comm-release?
Change how platform-specific CSS is done as suggested by frg
Attachment #9426607 -
Attachment is obsolete: true
Attachment #9426607 -
Flags: review?(frgrahl)
Attachment #9426607 -
Flags: approval-comm-release?
Attachment #9426639 -
Flags: review?(frgrahl)
Attachment #9426639 -
Flags: approval-comm-release?
|
||
Updated•2 months ago
|
|
|
||
Comment 3•2 months ago
|
||
Comment on attachment 9426639 [details] [diff] [review]
1920565-irc-channels-v1_1-25320.patch
lgtm
Attachment #9426639 -
Flags: review?(frgrahl)
Attachment #9426639 -
Flags: review+
Attachment #9426639 -
Flags: approval-comm-release?
Attachment #9426639 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5e642f669114
Tidy up channels code in cZ. r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•