Closed
Bug 1920610
Opened 1 year ago
Closed 1 year ago
moz-phab mocks are not calling `assert_` methods correctly resulting in a no-op
Categories
(Conduit :: moz-phab, defect, P3)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sheehan, Assigned: sheehan)
Details
Attachments
(1 file)
Some of the moz-phab mocks are calling methods like called_once instead of assert_called_once. Since the objects are mocks, these are no-ops, and are effectively testing nothing. In newer versions of our testing libraries the incorrect method name results in an exception in the test suite.
|
Assignee | |
Comment 1•1 year ago
|
||
In newer versions of Python, these misnamed mock calls trigger
failures. In the current versions they are effectively not
doing anything. Remove some assert calls since they fail when
called correctly, but don't test anything meaningful.
|
|
Assignee | |
Updated•1 year ago
|
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•1 year ago
|
Severity: -- → S4
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•