Closed Bug 1920633 Opened 2 months ago Closed 2 months ago

flex-basis should not accept `stretch` or `-webkit-fill-available`

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: dholbert, Unassigned)

References

(Blocks 2 open bugs)

Details

@yisibl observed in github that (when the property is preffed on) Firefox currently accepts flex-basis: -webkit-fill-available (and similarly flex-basis: stretch if that's preffed on.

https://drafts.csswg.org/css-sizing-4/#sizing-values has a list of properties that should accept stretch, and indeed flex-basis is not there in the list. So we should adjust the parsing code to reject it.

While we're at it, flex-basis should probably reject -moz-available as well, since (to the extent that it will live on at all) we'd like that keyword to essentially be an alias for the standards-based stretch, ideally.

Blocks: 1789477

Actually wait, the grammar for flex-basis is specced such that it accepts anything that width accepts (plus an additional keyword):
https://drafts.csswg.org/css-flexbox-1/#flex-basis-property

flex-basis
Value: 	content | <'width'>

So these values should in fact be supported by flex-basis after all (and perhaps the spec should list flex-basis to make that clear).

(flex-basis:stretch does seem a bit odd, but I suppose it's just another more-foolproof way of doing flex-basis:100% which is a perfectly reasonable thing to do.)

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.