1920646 - Make HTML inserters of `HTMLEditor` aware of `contenteditable=plaintext-only`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

document.execCommand("insertHTML") and the paste handlers.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1920646 - part 1: Make `HTMLEditor` paste/drop things as plaintext when `contenteditable=plaintext-only` r=m_kato!

Chrome sets beforeinput.data instead of beforeinput.dataTransfer, but
Input Events Level 2 spec defines that browsers should set dataTransfer when
contenteditable [1]. Therefore, the new WPT expects dataTransfer.

However, it's unclear that the dataTransfer should have text/html or only
text/plain. From web apps point of view, text/html data may make them
serialize the rich text format to plaintext without any dependencies of browsers
and OS. On the other hand, they cannot distinguish whether the user tries to
paste with or without formatting when contenteditable=true. Therefore, I
filed a spec issue for this. We need to be back later about this issue.

1. https://w3c.github.io/input-events/#overview
2. https://github.com/w3c/input-events/issues/162

Depends on D223670

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1920646 - part 2: Make `HTMLEditor` handle `insertHTML` as inserting plaintext converted from given source r=m_kato!

Depends on D223908

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e3f866560e2
part 1: Make `HTMLEditor` paste/drop things as plaintext when `contenteditable=plaintext-only` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/39f1a092f31f
part 2: Make `HTMLEditor` handle `insertHTML` as inserting plaintext converted from given source r=m_kato

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48435 for changes under testing/web-platform/tests

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2e3f866560e2
https://hg.mozilla.org/mozilla-central/rev/39f1a092f31f

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1920646 - Make `editing/plaintext-only` stop doing `.contentEditable = "plaintext-only"` r=m_kato!,#dom-core

If dom.element.contenteditable.plaintext-only.enabled is false,
the API throws an exception. Therefore, the following tests cannot check
the result. So, we should not use it. Instead,
.setAttribute("contenteditable", "plaintext-only") is fine.

Comment 8

[Phabricator Automation]

Comment on attachment 9428993 [details]
Bug 1920646 - Make editing/plaintext-only stop doing .contentEditable = "plaintext-only" r=m_kato!,#dom-core

Revision D224576 was moved to bug 1922712. Setting attachment 9428993 [details] to obsolete.