1920714 - [wpt-sync] Sync PR 48324 - Refactor selectlist tests [4/4]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48324 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48324
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Refactor selectlist tests [4/4]

This is a set of refactors that:

1. re-points existing WPTs and web_tests from \<selectlist> to
   \<select style="appearance:base".
2. renames tests from -selectlist- to -select-

These are done in batches, to make the review task easier. One CL
will re-point tests (without renaming them) and the next will do
the rename.

These are all in service of removing the \<selectlist> prototype.

Fixed: 335458492
Change-Id: I7eb34f254d713fd3e9a0123812f831df832a45fa
Reviewed-on: https://chromium-review.googlesource.com/5857252
WPT-Export-Revision: 14eed718cae6e35c4bddc27af189b5693a3bfeb9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 48324 applied with additional changes from upstream: b95e357e097f121b70dd853b4897302a46cca67c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f6cbded3a68abe84b22d7106fb2f7e0815fef7f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1f37ff522cb774c9aee413a7e27d0eaf9582962

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 17 tests

Status Summary

Firefox

OK : 13
PASS : 8
FAIL : 33

Chrome

OK : 12
PASS : 7
FAIL : 26
TIMEOUT: 1
ERROR : 1
NOTRUN : 7

Safari

OK : 13
PASS : 7
FAIL : 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/select-events.tentative.html [wpt.fyi]
  • Button controller code should not run if the click event is preventDefaulted.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Listbox controller code should not run if the click event is preventDefaulted.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • <select> should fire input and change events when new option is selected.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • <select> should fire input and change events even when new selected option has the same value as the old.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • <select> should fire input and change events when option in listbox is clicked: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Check that <Space> opens <select>.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Check that <Space> opens <select> when <select> specifies tabindex: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Test that <select> button slot receives key events.: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-keyboard.tentative.html [wpt.fyi]
  • Validate Enter, Up/Down Arrow, and Space keyboard accessibility support for <select>: FAIL (Chrome: FAIL, Safari: FAIL)
  • Validate Enter, Up/Down Arrow keyboard accessibility support for disabled <select>: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-many-options.tentative.html [wpt.fyi]
  • The popover should be bottom left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-option-focusable.tentative.html [wpt.fyi]
  • Validate <option> is focusable when is a descendant of <select>: FAIL (Chrome: PASS, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-popover-position-with-zoom.tentative.html [wpt.fyi]
  • The popover should be bottom left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
  • The popover should be top left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
  • The popover should be bottom right positioned: FAIL (Chrome: FAIL, Safari: FAIL)
  • The popover should be top right positioned: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-pseudo-light-dismiss-invalidation.tentative.html [wpt.fyi]
  • select should not match :open when light dismissed.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-pseudo-open-closed.tentative.html [wpt.fyi]
  • select should support :open and :closed pseudo selectors.: FAIL (Chrome: PASS, Safari: FAIL)
  • select :open and :closed should invalidate correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-tabindex-order.tentative.html [wpt.fyi]
  • Check that tabindex applies to <select>: FAIL (Chrome: FAIL, Safari: PASS)
• /html/semantics/forms/the-select-element/select-validity.tentative.html [wpt.fyi]
  • Validation for placeholder option: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-value-selectedOption.tentative.html [wpt.fyi]
  • Test that HTMLselect with no options has empty string for value and null for selectedOption: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test value and selectedOption with HTMLOptionElement element option parts: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test value and selectedOption when value is null: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test value and selectedOption when value is undefined: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test value with non-HTMLOptionElement elements labeled as parts: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that value and selectedOption are updated when options are removed: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that slotted-in selected-value part is updated to value of select: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that option parts in a slotted-in listbox are reflected in the value property: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that value and selectedOption are correctly updated: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that HTMLOption.selected updates select.value and select.selectedOption: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that HTMLOption.value updates select.value: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/select-option-label-rendering.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bee4f9efd55f
[wpt PR 48324] - Refactor selectlist tests [4/4], a=testonly
https://hg.mozilla.org/integration/autoland/rev/e49f74c839fe
[wpt PR 48324] - Update wpt metadata, a=testonly

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bee4f9efd55f
https://hg.mozilla.org/mozilla-central/rev/e49f74c839fe