Closed Bug 1920817 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 48329 - Support for @page counters.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48329 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48329
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Support for @page counters.

We need to create a deep clone of CountersAttachmentContext for each
page, since we may have to discard the page layout in some cases and
retry. Which means that we also need to roll back what was done to the
counters.

Page counters are rather special, when reset, they will obscure any
counters in the document (rather than establishing a new scope). This
even happens when incrementing page counters in some cases. Update
CountersAttachmentContext to handle this.

And, as always for block fragmentation, the out-of-flow layout code
needs a little special-treatment. If out-of-flow elements causes
additional pages to be created, we need to go back and reprocess all
page counters.

Bug: 40529222
Change-Id: I7c9c80114191ae760eab662ea7fd345237498945
Reviewed-on: https://chromium-review.googlesource.com/5887168
WPT-Export-Revision: 63a484b1b716d1459639483eba5c9cc8e24ee997

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 7 tests

Status Summary

Firefox

FAIL: 7

Chrome

PASS: 2
FAIL: 5

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6258988e568a [wpt PR 48329] - Support for @page counters., a=testonly https://hg.mozilla.org/integration/autoland/rev/75e6410cc625 [wpt PR 48329] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6258988e568a
https://hg.mozilla.org/mozilla-central/rev/75e6410cc625

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.