1920823 - [wpt-sync] Sync PR 48330 - Resolve relative colors for canvas 2d

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48330 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48330
Details from upstream follow.

Kevin Babbitt <[e-mail]> wrote:

Resolve relative colors for canvas 2d

In https://crrev.com/c/5825542 we deferred resolution of all relative
colors until after parse time for compatibility with expectations on
serialized values. Canvas 2d was still expecting these colors to be
resolved at parse time. The fix is to adjust the code to expect and
handle unresolved color functions.

Bug: 368562233
Change-Id: Iaafcab7cd45c0222317fe84343e3139a76fb1315
Reviewed-on: https://chromium-review.googlesource.com/5883454
WPT-Export-Revision: 6a9cd87e938d95c30f457b5eb483926861997a68

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bccdf5a75b2213061923fb8af22a0833b55a2e7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 1 subtests

Status Summary

Firefox

OK : 10
FAIL: 10

Chrome

OK : 10
FAIL: 10

Safari

OK : 10
PASS: 7
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/fill-and-stroke-styles/2d.fillStyle.relativecolor.currentcolor.html [wpt.fyi]
  • Relative color works as color input with currentcolor: FAIL (Chrome: FAIL, Safari: PASS)
• /html/canvas/element/fill-and-stroke-styles/2d.fillStyle.relativecolor.html [wpt.fyi]
  • Relative color works as color input: FAIL (Chrome: FAIL, Safari: PASS)
• /html/canvas/element/fill-and-stroke-styles/2d.gradient.relativecolor.html [wpt.fyi]
  • Relative color works as CanvasGradient color input: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.relativecolor.html [wpt.fyi]
  • Relative color works as color input: FAIL (Chrome: FAIL, Safari: PASS)
• /html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.relativecolor.html [wpt.fyi]
  • Relative color works as color input: FAIL (Chrome: FAIL, Safari: PASS)
• /html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.relativecolor.worker.html [wpt.fyi]
  • Relative color works as color input: FAIL (Chrome: FAIL, Safari: PASS)
• /html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.relativecolor.html [wpt.fyi]
  • Relative color works as CanvasGradient color input: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.relativecolor.worker.html [wpt.fyi]
  • Relative color works as CanvasGradient color input: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.relativecolor.html [wpt.fyi]
  • Relative color works as color input: FAIL (Chrome: FAIL, Safari: PASS)
• /html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.relativecolor.worker.html [wpt.fyi]
  • Relative color works as color input: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12d23eb2077b
[wpt PR 48330] - Resolve relative colors for canvas 2d, a=testonly
https://hg.mozilla.org/integration/autoland/rev/80a400e1505c
[wpt PR 48330] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/12d23eb2077b
https://hg.mozilla.org/mozilla-central/rev/80a400e1505c