1920829 - Formatting numbers in perfcompare

Status: NEW

(Testing :: PerfCompare, enhancement)

Description

[Paul Bone [:pbone]]

Attachment: Screenshot 2024-09-25 at 09-16-38 PerfCompare - Results.png

In the new perfcompare interface numbers aren't formatted with thousands separators, see the attached screenshot.

Where it says "15172608 bytes" I would prefer "15,172,608 bytes" or "14.47 MB" It should be locale dependant because thousands seperators are different in different parts of the world. and if converted into MB it should have a "sensible" number of significant digits.

Thank you.

Comment 1

[Julien Wajsberg [:julienw]]

Thanks for the bug!I agree that it's not great.
The problem with doing it locale dependent though, is that the rest of the interface isn't localized. So it would be confusing to (for example) see the numbers formatted as french but having the rest of the interface in english. Admittedly we could do it for the various english locales and default to some english region for non-english locale...

I wonder if one of the locale would be globally less confusing than the others. Maybe with spaces to separate the various groups?

Comment 2

[Paul Bone [:pbone]]

Mostly I didn't want to be insensitive and suggest that it must be 1,234,456.78 I do think this is an "okay" default though since I imagine most French people have seen numbers formatted this way while I was in my 30s before I saw 1.234.567,78

Comment 3

[akanksha.t05]

Hello, could i please work on this?

Comment 4

[Carla Severe [:carla]]

(In reply to akanksha.t05 from comment #3)

Hello, could i please work on this?

Hi, akanksha, if you are from Outreachy please wait until our contribution period opens on Oct 8th, 2024. Also, all Outreachy issues will be on Github and will have the label: #Outreachy-Issue. I appreciate your enthusiasm and patience. Please refer to the guidelines: Outreachy Guidelines for PerfCompare.