Closed Bug 1920960 Opened 11 months ago Closed 11 months ago

Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument

Categories

(Core :: DOM: Navigation, task)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox-esr128 --- fixed
firefox132 --- fixed
firefox133 --- fixed

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Bug 1920960 - Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument. r?farre!
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr128+
Details | Review

nsDocShellLoadState::CalculateChannelLoadFlags' aUriModified argument is a Maybe<bool>, but all callers have a value to pass in.

Assignee: nobody → peterv
Status: NEW → ASSIGNED
Type: defect → task
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc89b015d89e Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument. r=farre

https://hg.mozilla.org/mozilla-central/rev/cc89b015d89e

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch

Comment on attachment 9427051 [details]
Bug 1920960 - Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument. r?farre!

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Needed to uplift bug 1921972.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very simple clean-up
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9427051 - Flags: approval-mozilla-beta?

Comment on attachment 9427051 [details]
Bug 1920960 - Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument. r?farre!

Approved for 132.0b7.

Attachment #9427051 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9427051 [details]
Bug 1920960 - Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument. r?farre!

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed if we want to uplift bug 1911977.
  • User impact if declined: See bug 1911977
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial clean-up
Attachment #9427051 - Flags: approval-mozilla-esr128?

Comment on attachment 9427051 [details]
Bug 1920960 - Simplify nsDocShellLoadState::CalculateChannelLoadFlags argument. r?farre!

Approved for 128.4esr.

Attachment #9427051 - Flags: approval-mozilla-esr128? → approval-mozilla-esr128+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: