1920964 - [wpt-sync] Sync PR 48336 - Mark universal rules as covered by the universal bucket.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48336 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48336
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Mark universal rules as covered by the universal bucket.

We earlier concluded marking universal rules automatically as covered
wasn't worth it, but for the universal bucket, it makes more sense;
it doesn't cost much (because we put fewer rules in the universal
bucket), and it makes more selectors be considered easy. Especially
the case “.foo *” is moderately common.

This is generally imperceptible in our benchmarks, so it is mostly
because it feels sane. It is, however, measurable in how many selectors
in the style perftest go through the different paths:

Entirely covered by bucketing: 20.5% → 22.2%
Easy selectors: 34.7% → 34.8%
Full selector checking: 44.7% → 43.0%

This uncovered a bug where easy selector checking (and bucket trusting)
would be inadvertently activated for the shadow host, even though it
does not understand that it should be featureless. Properly disable it
in those cases.

Change-Id: Ieb09dd42c4594110d92a4eccb262302e8c0116c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5876029
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Steinar H Gunderson \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1359864}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a061d6f7af43e1c315a5287f3d41c59611f5e4b1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee47d8973c12
[wpt PR 48336] - Mark universal rules as covered by the universal bucket., a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ee47d8973c12