1921008 - Add Trusted Types pre-navigation check WPT for form-submission

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1921008: part 1) Factor duplicated code from <navigation-support.html> and <navigation-report-only-support.html> out. r=tschuster

The factored out code will be extended in the next part.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1921008: part 2) Add assertions to <trusted-types-navigation.html>. r=tschuster

Before, the sub-tests passed without any assertions, hampering checking
whether the tests were indeed correct.

Depends on D223593

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1921008: part 3) Remove event listener when desired event was received in <trusted-types-navigation.html>. r=tschuster

Previously, the event listeners of a previous test run would stay,
contributing to the set of assertions of the current test run.

Depends on D223594

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1921008: part 6) Add javascript-url navigation via form-submission tests for Trusted Types. r=tschuster

Depends on D223595

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1921008: part 4) Remove checking `trusted-types` as effective directive in <trusted-types-navigation.html>. r=tschuster

It was confusing.

Depends on D223595

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1921008: part 5) Clarify click-loop-breaking mechanism in <trusted-types-navigation.html>. r=tschuster

Before, <navigation-support.html> didn't correctly break the loop, as it
didn't use hashes.

Depends on D223753

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15c7ca4e6fd3
part 1) Factor duplicated code from <navigation-support.html> and <navigation-report-only-support.html> out. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/81dc54226b76
part 2) Add assertions to <trusted-types-navigation.html>. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/578331c28bb3
part 3) Remove event listener when desired event was received in <trusted-types-navigation.html>. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/0778f75c7ba9
part 4) Remove checking `trusted-types` as effective directive in <trusted-types-navigation.html>. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/1e668345dab2
part 5) Clarify click-loop-breaking mechanism in <trusted-types-navigation.html>. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/999a70cf9b2d
part 6) Add javascript-url navigation via form-submission tests for Trusted Types. r=tschuster

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48594 for changes under testing/web-platform/tests

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/15c7ca4e6fd3
https://hg.mozilla.org/mozilla-central/rev/81dc54226b76
https://hg.mozilla.org/mozilla-central/rev/578331c28bb3
https://hg.mozilla.org/mozilla-central/rev/0778f75c7ba9
https://hg.mozilla.org/mozilla-central/rev/1e668345dab2
https://hg.mozilla.org/mozilla-central/rev/999a70cf9b2d

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot