1921009 - ./mach mochitest --no-install fails: UnboundLocalError: cannot access local variable 'metadata' where it is not associated with a value

Status: RESOLVED FIXED

(Fenix :: Tooling, defect)

Description

[Jamie Nicol [:jnicol]]

Bug 1883086 seems to have broken the --no-install argument to mach mochitest (and presumably other mach commands too). I get the following error:

UnboundLocalError: cannot access local variable 'metadata' where it is not associated with a value

  File "/Volumes/src/gecko/testing/mochitest/mach_commands.py", line 459, in run_mochitest_general
    verify_android_device(
  File "/Volumes/src/gecko/testing/mozbase/mozrunner/mozrunner/devices/android_device.py", line 479, in verify_android_device
    device.run_as_package = metadata.package_name

Seems like metadata needs to be initialized in a common code path rather than only in the install != InstallIntent.NO case?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883086

Comment 2

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1921009 - Fix scope of local variable metadata

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20ffa140f69b
Fix scope of local variable metadata r=ohall,nalexander

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/20ffa140f69b