1921020 - Allow search for traces by function call argument values

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The JS Tracer currently stores the function call arguments in the debugger redux store, but only show them via inline/popup previews.
It would be neat to able to able to search frames by argument values.
Looking for primitive data types is trivial, but search per object may require a followup.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1921020 - [devtools] Search for argument values in the live JS Tracer.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1921020 - [devtools] Instantiate only one object actor per JS object in the JS Tracer

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1921020 - [devtools] Use ObjectActorPool to instantiate and collect all Object Actors.

This dedicated pool class shared by all the actors instantiating Object Actors
(console, thread and tracer actors) is going to later help reuse the same
WeakMap logic to instantiate only one actor per unique JS value.

I also merged console and target actor to use the same pool
as they basically have the same lifecycle. This simplify lookups
by Actor IDs done for selected object actor or console table objects.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1921020 - [devtools] Ensure updating object front's form when re-using the same front instance.

When we communicate a previously notified object actor form,
which was notified through a prevent RDP event or method call,
we passed its actor's form (a.k.a. "grip").
This contains a snapshot of the object in order to be able to display a preview
of it at the time the object was processed in the backend.

Now, when we manipulate the same JS value in the backend,
we may notify about the same object actor instance, but the actor's form ("grip")
will be updated to match the current state of the object.

In the frontend, we need to process this new form/grip in the Object Actor front,
so that the previews are correctly updated over time.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1921020 - [devtools] Allow evaluating console results reusing the Tracer actor Object Actor Pool.

This helps ensure that the object actors returned by the console actor evaluation RDP request
are the same for the same JS values being processed and notified via the tracer ressources.
This allows identifying same objects when doing a search per value.

Comment 6

[Phabricator Automation]

Comment on attachment 9430183 [details]
Bug 1921020 - [devtools] Use ObjectActorPool to instantiate and collect all Object Actors.

Revision D225235 was moved to bug 1923903. Setting attachment 9430183 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9430184 [details]
Bug 1921020 - [devtools] Ensure updating object front's form when re-using the same front instance.

Revision D225236 was moved to bug 1923903. Setting attachment 9430184 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9427499 [details]
Bug 1921020 - [devtools] Instantiate only one object actor per JS object in the JS Tracer

Revision D223782 was moved to bug 1923903. Setting attachment 9427499 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f807adadf05
[devtools] Allow evaluating console results reusing the Tracer actor Object Actor Pool. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b0ee34e44bb0
[devtools] Search for argument values in the live JS Tracer. r=devtools-reviewers,nchevobbe

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_dbg-javascript-tracer-sidebar-values-search.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/6761cdf112b85bd58bc928afc4b96de38d6d6f87

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-javascript-tracer-sidebar-values-search.js | Uncaught exception in test bound - at chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:1106 - Error: Failed waitFor():

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f807adadf05
https://hg.mozilla.org/mozilla-central/rev/b0ee34e44bb0

Comment 12

[amarc]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/6761cdf112b85bd58bc928afc4b96de38d6d6f87

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b954e5723fe
[devtools] Allow evaluating console results reusing the Tracer actor Object Actor Pool. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a2fcf48ee4fd
[devtools] Search for argument values in the live JS Tracer. r=devtools-reviewers,nchevobbe

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5b954e5723fe
https://hg.mozilla.org/mozilla-central/rev/a2fcf48ee4fd