1921026 - [toolbar redesign] Blank space when interacting with an input element with navbar enabled and fixed toolbar

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: BlankSpace.mp4

Steps to reproduce

1. Have the navigation bar enabled - default in Nightly
2. Have the dynamic behavior for the toolbar disabled - Settings -> Customize -> Scroll to hide address bar and toolbar
3. Interact with any input element from a webpage

Expected behavior

No visual artifacts / inconsistencies

Actual behavior

There is a blank space (similar in height to that of the navbar) between the bottom of the webpage and the top of the toolbar

Device information

• Firefox version: Seen in current Nightly from 25 September, unsure about how old of an issue it is.

Any additional information?

• Does reproduce with both the toolbar set at the top and at the bottom
• Does not reproduce if the navbar is disabled

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Was thinking that this would be a recent regression but the issue reproduces even with code from one month ago.
Assuming this has always been an issue and need a new patch.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1921026 - Update engine view's bottom margin whenever the fixed navbar is shown or hidden r=#android-reviewers

Whenever the tab is configured with a fixed toolbar the engine view has it's bottom margin
set to the height of the bottom toolbar to ensure it it shown on top of it and no web content
is clipped.
When interacting with an input element in a webpage the addressbar remains shown so there
is no issue but the navbar gets hidden so the engine view's bottom margin has to be updated
to account for the new layout.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dafb6e4cb91
Update engine view's bottom margin whenever the fixed navbar is shown or hidden r=android-reviewers,skhan

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6dafb6e4cb91

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

This bug exist in old code but the navbar can only be enabled in Nightly so no need to uplift.