1921072 - Fix impression telemetry warning for restrict keywords and token alias engines results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Mandy Cheang [:mcheang][she/her]]

After Bug 1917992 landed, I noticed an warning:

 0:10.17 INFO Console message: [JavaScript Warning: 
"urlbar.impression.restrict_keyword_bookmarks - Unknown scalar."]

I need to add impression telemetry for restrict keywords to fix the warning.

Comment 1

[Mandy Cheang [:mcheang][she/her]]

After discussing with Marco, we decided not to add urlbar.impression.restrict_keyword_bookmarks. The warning also occurred for urlbar.impression.searchengines because those were not being recorded either.

The urlbar.impression.* code is designed to record URL impressions. We chose not to add categories like searchengines or restrict_keyword_* because these are not URL results.

Solution

The fix for this patch is to add an extra conditional check:

• If the result is a URL, we record a urlbar.impression.*.
• If the result is not a URL, we do not record it.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1921072 - Fix impression telemetry warning for restrict keywords and token alias engines results. r=mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d593d8df4b2
Fix impression telemetry warning for restrict keywords and token alias engines results. r=mak,urlbar-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1d593d8df4b2