1921125 - [Predictive back] remove unsupported back navigation APIs

Status: VERIFIED FIXED

(Fenix :: Homepage, task)

Description

[Mike a [:mavduevskiy]]

From the doc:

1. Migrate your system Back handling logic to AndroidX’s OnBackPressedDispatcher with an implementation of OnBackPressedCallback. For detailed guidance, see Provide custom back navigation.
2. Disable the OnBackPressedCallback when ready to stop intercepting the back gesture.
3. Stop intercepting back events via OnBackPressed or KeyEvent.KEYCODE_BACK.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Bug 1921125 - Remove onBackPressed override from HomeActivity

... and replace it with OnBackPressedCallback with the same behaviour.

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 1921125 - Remove onBackPressed override from CrashReporterActivity

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1921125 - Remove deprecated onBackPressed from Dialogs

Comment 4

[Joe M [:jmahon]]

Mike, assuming you're working on this, can you mark this as "assigned" instead of "New"?

Comment 5

[Mike a [:mavduevskiy]]

good point, Joe, fixed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa2c156a9bcf
Remove onBackPressed override from HomeActivity r=android-reviewers,petru
https://hg.mozilla.org/integration/autoland/rev/5fb0042bae1a
Remove onBackPressed override from CrashReporterActivity r=android-reviewers,petru
https://hg.mozilla.org/integration/autoland/rev/3b8b535b9bb0
Remove deprecated onBackPressed from Dialogs r=android-reviewers,petru

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/fa2c156a9bcf
https://hg.mozilla.org/mozilla-central/rev/5fb0042bae1a
https://hg.mozilla.org/mozilla-central/rev/3b8b535b9bb0

Comment 8

[Mike a [:mavduevskiy]]

Dear QE,
this patch migrated the app from deprecated onBackPressed() to a newer API. It would be nice to verify that this didn't introduce any changes to the way back navigation works now, an a variety of android versions and both for gesture navigation and button navigation. Thank you :)

Comment 9

[Mira Lobontiu (Android QA)]

Verified on the latest Fenix Nightly 134.0a1 from 11/15 with the following devices:

• Google Pixel 6 (Android 15),
• Samsung Galaxy A14 (Android 14),
• Xiaomi Mi8 Lite (Android 10),
• HTC 10 (Android 8),
• Google Pixel 9 Pro (Android 14),
• Sony Xperia Z5 Premium (Android 7.1.1),
• Samsung Galaxy Note 8 (Android 9),
• Vivo V23 (Android 14),
• Samsung Galaxy S24 (Android 14),
• Realme GT Master Edition (Android 13),
• Oppo Find X3 Lite (Android 11), and
• Samsung Galaxy Tab S9 Ultra (Android 14).