Closed Bug 1921125 Opened 1 month ago Closed 8 hours ago

[Predictive back] remove unsupported back navigation APIs

Categories

(Fenix :: Homepage, task)

All
Android
task

Tracking

(firefox134 fixed)

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: mavduevskiy, Assigned: mavduevskiy)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxdroid][group3])

Attachments

(3 files)

From the doc:

  1. Migrate your system Back handling logic to AndroidX’s OnBackPressedDispatcher with an implementation of OnBackPressedCallback. For detailed guidance, see Provide custom back navigation.
  2. Disable the OnBackPressedCallback when ready to stop intercepting the back gesture.
  3. Stop intercepting back events via OnBackPressed or KeyEvent.KEYCODE_BACK.
Type: enhancement → task
Assignee: nobody → mavduevskiy

... and replace it with OnBackPressedCallback with the same behaviour.

Attachment #9427286 - Attachment description: Bug 1921125 - Remove onBackPressed override from HomeActivity → WIP: Bug 1921125 - Remove onBackPressed override from HomeActivity
Attachment #9427291 - Attachment description: Bug 1921125 - Remove onBackPressed override from CrashReporterActivity → WIP: Bug 1921125 - Remove onBackPressed override from CrashReporterActivity
Blocks: 1898059
Attachment #9427639 - Attachment description: WIP: Bug 1921125 - Remove deprecated onBackPressed from Dialogs → Bug 1921125 - Remove deprecated onBackPressed from Dialogs
Attachment #9427291 - Attachment description: WIP: Bug 1921125 - Remove onBackPressed override from CrashReporterActivity → Bug 1921125 - Remove onBackPressed override from CrashReporterActivity
Attachment #9427286 - Attachment description: WIP: Bug 1921125 - Remove onBackPressed override from HomeActivity → Bug 1921125 - Remove onBackPressed override from HomeActivity
Whiteboard: [fxdroid][group3]

Mike, assuming you're working on this, can you mark this as "assigned" instead of "New"?

Flags: needinfo?(mavduevskiy)

good point, Joe, fixed

Flags: needinfo?(mavduevskiy)
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa2c156a9bcf Remove onBackPressed override from HomeActivity r=android-reviewers,petru https://hg.mozilla.org/integration/autoland/rev/5fb0042bae1a Remove onBackPressed override from CrashReporterActivity r=android-reviewers,petru https://hg.mozilla.org/integration/autoland/rev/3b8b535b9bb0 Remove deprecated onBackPressed from Dialogs r=android-reviewers,petru
Status: NEW → RESOLVED
Closed: 8 hours ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: