1921162 - Make `HTMLEditor` aware of inputting line breaks in `contenteditable=plaintext-only`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Chrome inserts a line break with either:

• typing Enter
• typing Shift + Enter
• execCommand("insertLineBreak")

Those cause input events whose inputType is insertLineBreak.

However, execCommand("insertParagraph") inserts an empty paragraph or split current paragraph as same as contenteditable=true. I'm not sure whether this is intentional.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Safari also supports insertParagraph working as same as in contenteditable=true. So, we need to follow them.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1921162 - part 1: Make `HTMLEditor` handle `Enter` key press as `insertLineBreak` if it's in `contenteditable=plaintext-only` r=m_kato!

Chrome treats Enter key press as insertLineBreak instead of
insertParagraph. Additionally, Chrome handles insertParagraph command
work as same as when contenteditable=true. Therefore, HTMLEditor needs
to change the behavior at handling eKeyPress event.

Depends on D224184

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1921162 - part 2: Add basic tests for `insertParagraph` in `contenteditable=plaintext-only` r=m_kato!

The behavior should be same as when contenteditable=true. Therefore,
this test checks only the basic behavior.

Depends on D224185

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f38500099558
part 1: Make `HTMLEditor` handle `Enter` key press as `insertLineBreak` if it's in `contenteditable=plaintext-only` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3856ef423b91
part 2: Add basic tests for `insertParagraph` in `contenteditable=plaintext-only` r=m_kato

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48462 for changes under testing/web-platform/tests

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f38500099558
https://hg.mozilla.org/mozilla-central/rev/3856ef423b91

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot