Closed Bug 1921185 Opened 1 year ago Closed 1 year ago

[Reader View] Add an option for justified text alignment

Categories

(Toolkit :: Reader Mode, enhancement)

Firefox 130
enhancement

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: popov895, Assigned: ini)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

Currently, Reader View has three options for text alignment: start, end, and center. It would be great if there was also an option for justified text alignment.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Reader Mode' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Reader Mode
Product: Firefox → Toolkit
Assignee: nobody → rhn0312
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Gave this enhancement a try as this ticket and Bug 1913738 are both requesting it. A couple notes:

  • May need to confirm with design team if align-justify-20.svg is encoded correctly, as I made it in Figma.
  • I made the RTL behavior so that the justify button remains as the last in the row.
  • Deviated from the "Align text {position}" labeling convention, as "Justify text" seemed more clear to me.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c2ee3fd68fcd Add an option for justified text alignment. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Regressions: 1953714
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: