Closed Bug 1921278 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 48350 - [css-scroll-snap-2] Make scroll-start-target single-param

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48350 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48350
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

[css-scroll-snap-2] Make scroll-start-target single-param

Per the spec[1], this patch makes the scroll-start-target property take
a single argument, and makes it no longer a shorthand.

The syntax used to be:
scroll-start-target: \<block> \<inline>
where \<block> and \<inline> could be "auto" or "none",
but it should now be:
scroll-start-target: [auto|none]

Follow-up work:

Now that the property no longer differentiates the axes, each
scroll-start-target is to be scrolled to in both axes. The
CSSWG has resolved[2] to handle competing scroll-start-targets by
scrolling to each one in reverse-DOM-order. This patch only handles the
change in parsing, a follow-up patch will handle the resolution of
competing targets.

[1] https://drafts.csswg.org/css-scroll-snap-2/#scroll-start-target
[2] https://github.com/w3c/csswg-drafts/issues/10774#issuecomment-2358920264

Bug: 40909052, 368038561
Change-Id: I2a773dd8d4291602c6b69f47e0e648fd8a28e1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881188
Commit-Queue: David Awogbemila \<awogbemila@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1360557}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 4 subtests

Status Summary

Firefox

OK : 4
PASS: 5
FAIL: 8

Chrome

OK : 4
PASS: 13

Safari

OK : 4
PASS: 5
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05fe12d898f2 [wpt PR 48350] - [css-scroll-snap-2] Make scroll-start-target single-param, a=testonly https://hg.mozilla.org/integration/autoland/rev/606c620439d9 [wpt PR 48350] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.