[wpt-sync] Sync PR 48350 - [css-scroll-snap-2] Make scroll-start-target single-param
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox133 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 48350 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/48350
Details from upstream follow.
David Awogbemila <awogbemila@chromium.org> wrote:
[css-scroll-snap-2] Make scroll-start-target single-param
Per the spec[1], this patch makes the scroll-start-target property take
a single argument, and makes it no longer a shorthand.The syntax used to be:
scroll-start-target: \<block> \<inline>
where \<block> and \<inline> could be "auto" or "none",
but it should now be:
scroll-start-target: [auto|none]Follow-up work:
Now that the property no longer differentiates the axes, each
scroll-start-target is to be scrolled to in both axes. The
CSSWG has resolved[2] to handle competing scroll-start-targets by
scrolling to each one in reverse-DOM-order. This patch only handles the
change in parsing, a follow-up patch will handle the resolution of
competing targets.[1] https://drafts.csswg.org/css-scroll-snap-2/#scroll-start-target
[2] https://github.com/w3c/csswg-drafts/issues/10774#issuecomment-2358920264Bug: 40909052, 368038561
Change-Id: I2a773dd8d4291602c6b69f47e0e648fd8a28e1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881188
Commit-Queue: David Awogbemila \<awogbemila@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1360557}
| Assignee | ||
Updated•2 years ago
|
| Assignee | ||
Comment 1•2 years ago
|
||
| Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 4 tests and 4 subtests
Status Summary
Firefox
OK : 4
PASS: 5
FAIL: 8
Chrome
OK : 4
PASS: 13
Safari
OK : 4
PASS: 5
FAIL: 8
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-scroll-snap-2/parsing/scroll-start-target-computed.html [wpt.fyi]
- Property scroll-start-target value 'auto':
FAIL(Chrome:PASS, Safari:FAIL) - Property scroll-start-target value 'none':
FAIL(Chrome:PASS, Safari:FAIL)
- Property scroll-start-target value 'auto':
- /css/css-scroll-snap-2/parsing/scroll-start-target-valid.html [wpt.fyi]
- e.style['scroll-start-target'] = "none" should set the property value:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['scroll-start-target'] = "auto" should set the property value:
FAIL(Chrome:PASS, Safari:FAIL)
- e.style['scroll-start-target'] = "none" should set the property value:
- /css/css-scroll-snap-2/scroll-start-target/scroll-start-target-nested-container.tentative.html [wpt.fyi]
- display:none scroll-start-target becomes display:block:
FAIL(Chrome:PASS, Safari:FAIL) - intermediate overflow:visible container becomes overflow:scroll:
FAIL(Chrome:PASS, Safari:FAIL) - inner scroll-start-target takes precedence over outer:
FAIL(Chrome:PASS, Safari:FAIL) - scroll containers can also be scroll-start-targets:
FAIL(Chrome:PASS, Safari:FAIL)
- display:none scroll-start-target becomes display:block:
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/05fe12d898f2
https://hg.mozilla.org/mozilla-central/rev/606c620439d9
Description
•