192133 - 'Redo' item is missing in the context menu of message body

Status: RESOLVED WONTFIX

(MailNews Core :: Composition, defect)

Description

[[e-mail]]

Per bug 172047 the 'Redo' item was added to all the text fields in Mozilla, such
as the subject. But it is still missing from the message body context menu.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Cavin Song]

Comment on attachment 113697 [details] [diff] [review]
Proposed patch

r=cavin.

Comment 3

[(not reading, please use [e-mail] instead)]

are we sure this is something we really want?

see blake's comment http://bugzilla.mozilla.org/show_bug.cgi?id=172047#c23

"It made no sense to "fix" this.  Windows doesn't have Redo in textbox context
menus, and for good reason -- it's hardly ever used.  Blind consistency isn't
always a good thing."

the mailnews compose spec doesn't cover it (see
http://www.mozilla.org/mailnews/specs/compose/)

let's wait for jglick to comment (that might be a while). 

let's hold off unless someone else has some usability data or examples of where
apps have both undo / redo in the context menu.

Comment 4

[[e-mail]]

Note that Editor has a Redo context menu item (when available).

Comment 5

[jglick]

I would agree if we don't feel its a commonly used item, it shouldn't be in the
context menu. In order to avoid huge context menus, we should limit them to the
more frequently used actions.

http://www.mozilla.org/mailnews/specs/compose/Comp_Menus.html#ContextSpecificMenus

Subject Field - toggle Undo/Redo
Context Area - no Undo or Redo.

Comment 6

[[e-mail]]

Oh, so would you like to have Undo removed from the content area context menu?
Or perhaps you would prefer to see them only when they are available?

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 113697 [details] [diff] [review]
Proposed patch

rejected, based on the feedback from jglick.

should this be wontfix, or should we morph this into the spin off issue?