Closed Bug 1921376 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 48357 - [text-box-trim] Fix `text-box-trim-initial-letter-start-001-ref`

Categories

(Core :: Layout: Block and Inline, task, P4)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48357 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48357
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[text-box-trim] Fix text-box-trim-initial-letter-start-001-ref

This patch fixes the test to be interoperable.

It turned out that the font size of raised initial letters is
undefined[1], and implementations have different issues
especially when using Ahem as a web font.

To make this test focus on if the text-box-trim property
trims the raised part, this patch fixes the ref file to
compute the position dynamically.

Locally tested on Blink and WebKit TP with -webkit- prefix
added to the initial-letter property.

[1] https://drafts.csswg.org/css-inline-3/#sizing-initial-letter

Bug: 367766472, 40254880
Change-Id: Ia9a1aae881762f390967fc3b29b9ca33515e4d8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892982
Auto-Submit: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Lingqi Chi \<lingqi@chromium.org>
Commit-Queue: Lingqi Chi \<lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1360862}

Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d6a9e3772a5 [wpt PR 48357] - [text-box-trim] Fix `text-box-trim-initial-letter-start-001-ref`, a=testonly https://hg.mozilla.org/integration/autoland/rev/ea343b319271 [wpt PR 48357] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.