1921412 - Manually set `app.update.langpack.enabled=false` to work around bug 1168178

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[John Bieling (:TbSync)]

Thunderbird would like to enable the app.update.langpack.enabled pref globally in its main preference file /comm/mail/app/profile/all-thunderbird.js, similar to what Firefox is doing already in its counterpart file /browser/app/profile/firefox.js (here).

However, if we do that, the following toolkit test starts to fail:

/toolkit/mozapps/update/tests/unit_aus_update/disableBackgroundUpdatesNonBackgroundTask.js

The reason is that the test ignores global preferences for Firefox, but not for Thunderbird. This is due to bug 1168178 and bug 755724: Firefox does not load its global preferences unless the manifest specifically requests it by specifying firefox-appdir = browser.

The test which fails needs app.update.langpack.enabled to be unset or false.

I therefore propose to set the required preference in the manifest.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1921412 - Set `app.update.langpack.enabled=false` in `toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml`. r=nalexander

The test

/toolkit/mozapps/update/tests/unit_aus_update/disableBackgroundUpdatesNonBackgroundTask.js

needs app.update.langpack.enabled to be unset or false.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c22f4b7a4456
Set `app.update.langpack.enabled=false` in `toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml`. r=application-update-reviewers,nalexander

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c22f4b7a4456

Comment 4

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/5b88b669dcb7