192142 - need packages-* file for Mach-O builds

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

do we need packages-* file for Mach-O builds?

from a conversation between ccarlen and me:

sspitzer: I'm moving some stuff from moz to ns, and I want to make sure it is 
part of the Mach-O end package.
sspitzer: for Mach-O, for the mozilla (and ns) tree, what's the right packages 
file to make changes to?
sspitzer: is it packages-mac?

ccarlen: we actually don't have a packages file...
ccarlen: which I recently discovered. dist/bin is copied straight into the end 
package

sspitzer: I wonder if stuff we don't need or want is ending up in the mach-o 
end package

ccarlen: yes - I just checked in a change to reduce a meg of that
ccarlen: we were building an extra version of xpcom (libxpcom.bundle) which was 
unused (and it was 1 meg in size)

sspitzer: so you just stopped building it?

ccarlen: yeah
ccarlen: but, I think we need a package

Comment 1

[J.J. Enser]

right, we currently don't rely on the packages-mac file for the Mach-O build. As
Conrad said, we copy the binary from mozilla/dist/Mozilla.app and remove a few
files from inside the bundle (hard-coded in the packaging automation):

# Remove files that we don't need to distribute
rm -f bloaturls.txt dirver mozilla mozilla-config nsinstall regExport
run-mozilla.sh timebombgen xpcshell xpidl xpt_dump xpt_link
(all are in Mozilla.app/Contents/MacOS)

If the recommendation is to use packages-mac to properly trim the application
bundle content, we'll need to enhance either the build script
(xpfe/bootstrap/Makefile.in) or the packaging automation, the same way we were
doing for the carbon cfm build, ignoring the modules defined in that file
([browser] [mail], etc.)

Comment 2

[J.J. Enser]

retargetting to 1.5b, the next milestone I'll be working on.
Reassign if this needs to happen before. (and look at buildCentral to see how
pkgcp.pl was called for the cfm carbon build)

Comment 3

[Conrad Carlen (not reading bugmail)]

*** Bug 203106 has been marked as a duplicate of this bug. ***

Comment 4

[Simon Fraser [no longer active]]

I think we'll have to use a packages-macho to copy from dist/Mozilla{Debug}.app
to {targetdir}/Mozilla{Debug}.app. Apparently the release build process does
some stripping of stuff from the package, which we'd then want to remove.

Since JJ is away, taking this.

Comment 5

[Simon Fraser [no longer active]]

Attachment: WIP patch

I don't have time to work on this any more, but here's what I have so far.

Comment 6

[Simon Fraser [no longer active]]

Over to default owner

Comment 7

[(default assignee for unassigned bugs. does not receive bugmail)]

Mass reassign of Build/Config bugs to Leaf.

Comment 8

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 9

[J. Paul Reed [:preed]]

Mass re-assign of bugs that aren't on the build team radar, so bugs assigned to [e-mail] reflects reality.

If there is a bug you really think we need to be looking at, please *email* [e-mail] with a bug number and explanation.

Comment 10

[Stefan [:stefanh]]

We have a packages file, so this is wfm.