1921480 - Make internalRedirectTo transparent.

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Sean Kim [:sekim]]

The redirection occurs from empty.html to console.html (both are test pages from the Puppeteer test suite). Although the browser's URL bar displays "empty.html" and location.href is set to "empty.html", the page is actually constructed using the content from "console.html". This behaviour is present in Chrome.

As mentioned in Bug 1898158 Patch, the initial request is for "/webdriver/tests/bidi/network/support/empty.html?1", then we redirect (internalRedirectTo) to "/webdriver/tests/bidi/network/support/empty.html?2". The redirect from Bug 1905037 ends up loading "empty.html?2", yet we want window.location.href and URL bar to be "/webdriver/tests/bidi/network/support/empty.html?1" not "/webdriver/tests/bidi/network/support/empty.html?2".

As Kershaw mentioned, we can probably set a flag REDIRECT_TRANSPARENT instead of REDIRECT_INTERNAL, then in nsHttpHandler::AsyncOnChannelRedirect, verify if REDIRECT_TRANSPARENT is set and call OnRedirectVerifyCallback(NS_OK);. This way, we can avoid notifying the observers.

We should rename the API to transparentRedirectTo.

Comment 1

[Sean Kim [:sekim]]

Attachment: Bug 1921480 - Make internalRedirectTo transparent r=kershaw,jdescottes

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4334a934970b
Make internalRedirectTo transparent r=kershaw,jdescottes,necko-reviewers

Comment 3

[Sean Kim [:sekim]]

Attachment: Bug 1921480 - transparentRedirectTo should increment internalRedirectCount not redirectCount r=kershaw,jdescottes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/161a75a2d9ca
transparentRedirectTo should increment internalRedirectCount not redirectCount r=kershaw,jdescottes,necko-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4334a934970b

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/161a75a2d9ca