Open Bug 1921480 Opened 3 days ago Updated 3 days ago

Make internalRedirectTo transparent.

Categories

(Core :: Networking, task, P2)

task

Tracking

()

People

(Reporter: sekim, Assigned: sekim)

References

(Depends on 1 open bug)

Details

(Whiteboard: [necko-triaged][necko-priority-next])

Attachments

(1 file)

The redirection occurs from empty.html to console.html (both are test pages from the Puppeteer test suite). Although the browser's URL bar displays "empty.html" and location.href is set to "empty.html", the page is actually constructed using the content from "console.html". This behaviour is present in Chrome.

As mentioned in Bug 1898158 Patch, the initial request is for "/webdriver/tests/bidi/network/support/empty.html?1", then we redirect (internalRedirectTo) to "/webdriver/tests/bidi/network/support/empty.html?2". The redirect from Bug 1905037 ends up loading "empty.html?2", yet we want window.location.href and URL bar to be "/webdriver/tests/bidi/network/support/empty.html?1" not "/webdriver/tests/bidi/network/support/empty.html?2".

As Kershaw mentioned, we can probably set a flag REDIRECT_TRANSPARENT instead of REDIRECT_INTERNAL, then in nsHttpHandler::AsyncOnChannelRedirect, verify if REDIRECT_TRANSPARENT is set and call OnRedirectVerifyCallback(NS_OK);. This way, we can avoid notifying the observers.

We should rename the API to transparentRedirectTo.

Assignee: nobody → sekim
Severity: -- → N/A
Depends on: 1905037, 1898158
Priority: -- → P2
Whiteboard: [necko-triaged][necko-priority-next]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: