1921483 - Add "see details" link to the alert dialog shown on addon-install-failed on Firefox Desktop builds

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: ux-specs--install-addon-failed--softblocked.png

Per soft-blocks UX specs, we'd like to show a "See details" link in the install-addon-failed-notification dialog shown on Firefox Desktop when an add-on install has failed because the addon is softblocked (same as Bug 1921417 but for Firefox Desktop builds).

To introduce a new link into the install-addon-failed-notification dialog we will likely:

• add an explicit popupnotification with id install-addon-failed-notification in browser/base/content/popup-notifications.inc with the link element initially hidden by default
• then on the browser/base/content/browser-addons.js side, additional logic to populate the link url in the link element and show/hide the link element based on the error for which we are showing the install-addon-failed-notification dialog

In addition to that we will then need to tweak accordingly the related mochitests covering the install-addon-failed-notification (e.g. the following test files: toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js, toolkit/mozapps/extensions/test/browser/browser_local_install.js, toolkit/mozapps/extensions/test/browser/browser_webapi_install.js)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1921483 - Add 'See details' link to the alert dialog shown on addon-install-failed on Firefox Desktop. r?willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1921483 - Explicitly cover expected behavior on clicking the blocklist info url in the install failure dialog.

Depends on D225107

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd8952bbc14d
Add 'See details' link to the alert dialog shown on addon-install-failed on Firefox Desktop. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bd8952bbc14d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f82cc33da0b
Explicitly cover expected behavior on clicking the blocklist info url in the install failure dialog. r=willdurand

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9f82cc33da0b