1921509 - Thumbs up/down buttons jump to a different location (no longer in bottom-right corner) after "Saved to Pocket" appears

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Be signed in to Pocket (so that the pocket button can work, on new-tab suggested-story tiles)
2. Click the "Save" button on a new-tab suggested-story tile.
3. Hover that tile and compare the thumbs-up/down button locations, vs. another tile for a pocket story that you haven't saved.

ACTUAL RESULTS:
The thumbs-up/down buttons shift upwards, leaving the bottom-right corner (where they previously were) awkwardly empty. (It seems that they're pushed up by the "Saved to Pocket" badge.)

EXPECTED RESULTS:
Thumbs-up/down buttons should remain in the same location at bottom-right corner; they look awkward in their shifted-upwards location.

If we don't want these buttons to be alongside the "Saved to pocket" badge, then I'd suggest we move "Saved to pocket" badge upwards, rather than the thumbs-up/down buttons. The thumbs-up/down buttons are present on every tile (when hovered) so it looks a bit odd if they're in a different place on some tiles vs. others.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing thumbs-up/down buttons shifted upwards to dodge "Saved to Pocket" badge

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: reference screenshot showing expected position of thumbs-up/down buttons (bottom right corner)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screencast of me clicking "Save" on some tiles, causing tile heights to change and thumbs-up/down buttons jumping upwards

Relatedly: if I click "Save" on a tile that's the tallest one in a row (the one whose blurb text extends down to nearly the bottom of the tile), then the "Saved to Pocket" badge increases the height of that tile (and hence the whole row) when it appears, since that badge steals its own vertical space.

Not sure if we want to pre-reserve some space for that Saved to Pocket badge, and/or try to lay it out to the left of the thumbs-up/down buttons (if there's enough width to place it there), to avoid both the thumbs-up/down buttons moving and to avoid the tile-height-changing?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Maxx Crawford [:maxx]]

Triage reasoning:

• Severity: -- → S3: Work around exists for this issue
• Priority: -- → P3: Backlog