1921538 - Sidebar settings says "Show on left" in RTL when the sidebar is on the right and vice-versa

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: sidebar-rtl-settings-strings.png

Sidebar settings say "Show on left" in RTL when the sidebar is on the right and vice-versa. When the sidebar is in the "inline-start" position in RTL it is actually on the right of the window, and similarly if you move it to position end, it appears on the left. The labels in settings should reflect this.

STR:

• set sidebar.revamp preference to true.
• use a RTL locale or set the intl.l10n.pseudo preference to bidi
• open the sidebar settings panel

ER:

• The settings labels should reglect the actual position the sidebar will apear in if we are using explicit, positional terms like "left" and "right"

AR:

• The settings labels are effectively reversed, indicating the sidebar is on the left when its on the right, and right when its on the left.

Comment 1

[Ania]

Just noting for prioritization that we will exclude RTL locales from the 132 experiments (as we can't optimize onboarding in time).

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Resolved as part of Bug 1939917 settings update