1921571 - Can't access property "id", selectedLocation.sourceActor is null

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Brandon Cannon]

Error:
TypeError: can't access property "id", selectedLocation.sourceActor is null

React Component Stack:
in Connect(SourceFooter)
in div
in main
in div
in div
in SplitBox
in div
in div
in SplitBox
in AppErrorBoundary
in div
in App
in Connect(App)
in Provider
in Provider

Stacktrace:
mapStateToProps@resource://devtools/client/debugger/src/components/Editor/Footer.js:339:89
mapToPropsProxy@resource://devtools/client/shared/vendor/react-redux.js:1776:92
handleNewState@resource://devtools/client/shared/vendor/react-redux.js:1937:41
handleSubsequentCalls@resource://devtools/client/shared/vendor/react-redux.js:1954:30
pureFinalPropsSelector@resource://devtools/client/shared/vendor/react-redux.js:1959:32
runComponentSelector@resource://devtools/client/shared/vendor/react-redux.js:1233:39
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1406:23
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:38:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:84:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
loadSourceMap/<@resource://devtools/client/debugger/src/actions/sources/newSources.js:99:15

Comment 1

[Hubert Boma Manilla (:bomsy)]

Looks like this might be missing a check for the existence of the sourceActor here. Its already done in the 2 other places

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1921571 - [devtools] Make sure source actor exist for isSourceActorWithSourceMapProp check r=#devtools-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe8dd3c77a91
[devtools] Make sure source actor exist for isSourceActorWithSourceMapProp check r=devtools-reviewers,ochameau

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fe8dd3c77a91