1921662 - The SVG text along a path becomes misaligned in Firefox Developer Edition when the path has a non-1 scale transform, unlike in other browsers where it displays correctly.

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[nico [:nickname]]

Attachment: text-align-bug-in-ffde.svg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

1. Create an SVG with a path using the transform attribute with a non-1 scale.
2. Add text along the path using <textPath>.
3. View the SVG in Firefox Developer Edition and compare with Firefox or other browsers.

Environment:

• Firefox Developer Edition Version: 131.0b9
• Operating System: macOS 14.7

Additional Information:

• This issue is reproducible with other SVG examples using similar path scaling.
• Tested and confirmed to work correctly in Chrome, Safari, and Firefox.

The bug can also be seen in this example:
https://nichub.github.io/enneascope/

Actual results:

The text appears shifted or displaced relative to the path when a scale other than 1 is applied.

Expected results:

The text should align correctly along the path, regardless of the scale applied.

Comment 1

[Robert Longson [:longsonr]]

probably a regression from bug 878346

Comment 2

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Would be nice not to ship this but also we just came out of soft freeze so probably too late.

Comment 3

[Dianna Smith [:diannaS]]

We can consider it for the Oct 15 131 dot release.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1921662 - Ignore transform-origin and such shenanigans in SVGGeometryElement::LocalTransform. r=longsonr

We don't want the offsetted matrix, just the actual transform matrix
specified on the element.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Need to write a test if nothing breaks: https://treeherder.mozilla.org/jobs?repo=try&revision=be0f5a59d5ccd020fe7bdd1beb025f70ca0c8f2b

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Added a test, the failures above were from another patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd364824053b
Ignore transform-origin and such shenanigans in SVGGeometryElement::LocalTransform. r=longsonr

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48466 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Robert Longson [:longsonr]]

https://hg.mozilla.org/mozilla-central/rev/dd364824053b80e505688cfb4bf8a2f17b70019a

Comment 11

[Robert Longson [:longsonr]]

Comment on attachment 9428269 [details]
Bug 1921662 - Ignore transform-origin and such shenanigans in SVGGeometryElement::LocalTransform. r=longsonr

Beta/Release Uplift Approval Request

• User impact if declined: SVG text that uses textPath will be misrendered if the path is scaled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change is scoped to path scaling when used by textPath elements
• String changes made/needed: none
• Is Android affected?: Yes

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dd364824053b

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9428269 [details]
Bug 1921662 - Ignore transform-origin and such shenanigans in SVGGeometryElement::LocalTransform. r=longsonr

Approved for 132.0b4.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1a84a88840a2

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9428269 [details]
Bug 1921662 - Ignore transform-origin and such shenanigans in SVGGeometryElement::LocalTransform. r=longsonr

Approved for 131.0.3 dot release

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/401d93f60670