1921677 - firefox on GNU/Linu deep bookmark folders, deep folders inside "Open All Bookmarks" doesn't work, it's not even clickable

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[tysingibson514]

Attachment: file.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

create a "bookmark folder" on "Bookmarks Toolbar", then inside that folder create another "bookmark folder", then inside that folder put some links or sites say about 4, now open those 4 links by opening the "outer folder" which will expose or be able to see the "inner folder" this "inner folder" has the 4 links or sites, right click the "inner folder" then click "Open All Bookmarks", this "Open All Bookmarks" doesn't work

Actual results:

it should open all 4 links but, it doesn't open, "Open All Bookmarks" is not even clickable

Expected results:

it should open all 4 links

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0f9cd4dbd0d1d29328bd7c8cc8a701a8ec009554&tochange=8e09abeeb445553bd956d537bcf54fcdf812bb52

Suspect: Bug 1804247

Tentatively, mark Bug 1804247 as culprit.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:Oriol, since you are the author of the regressor, bug 1804247, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Oriol Brufau [:Oriol]]

(In reply to Alice0775 White from comment #2)

Suspect: Bug 1804247

Why? Seems quite unrelated, but I can't test now.

Comment 5

[tysingibson514]

I'm sorry, I'm new here, I'm just trying give light on my problem with Firefox on my Arch GNU/Linux machine, running wayland and hyprland, I don't even know what's the meaning by here on "regression", I just have a standard firefox, which I got from running "# pacman -S firefox", if someone could just give me a link to a guide to what's the meaning of all these options on reporting a bug on firefox, that would be very much appreciated. I don't even know to where could I find the list of keywords and it's meaning and all this, if someone could just give me a link to the guide these options on creating a bug report I would very much appreciate that.

Comment 6

[Oriol Brufau [:Oriol]]

It's fine, thanks for reporting, it's just that Alice thinks the problem that you found was caused by my patch, and I have doubts about that. I will be able to investigate whether it really was the culprit in a few days.

Most keywords are explained https://bugzilla.mozilla.org/describekeywords.cgi, but don't worry too much about them.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1804247

Comment 8

[Oriol Brufau [:Oriol]]

I can't reproduce the problem, works fine for me on Nightly 132.0a1 (2024-09-21) running on Ubuntu 22.04 with KDE plasma, using X.
Unlinking 1804247 which seems totally unrelated.

Comment 9

[Alice0775 White]

screencast https://youtu.be/oJsS_UB7B-s

STR:

1. Left mouse click on a folder on Bookmarks toolbar
2. Move mouse pointer on a sub-folder
3. Right mouse button down on the sub-folder and do not release the mouse button
4. Move mouse pointer on the context menu item while hold right mouse button down
   --- no hover highlight appears on context menu items --- BUG
5. Mouse button release on a context menu item
   --- nothing happens --- BUG

Comment 10

[Oriol Brufau [:Oriol]]

(In reply to Alice0775 White from comment #9)

3. Right mouse button down on the sub-folder and do not release the mouse button

OK, I was releasing the mouse button.

Comment 11

[tysingibson514]

I tried it on my other machine still running Arch GNU/Linux but not running wayland, it's running X, it has no problem on firefox( version 131.0 ) bookmark folder, on my main computer( firefox version 130.0.1 ) the problem still exist, sometimes it works but sometimes it doesn't that is on the "Open All Bookmark" button, here a video https://drive.google.com/file/d/1yz6EZbO3FdxhYZPBqCefwZMK6YRJE8Fi/view?usp=sharing

but dragging the bookmark folder works

but it would be nice for "Open All Bookmarks" button to work, it only works on the first layer of folder if you go deeper "Open All Bookmarks" button rarely works, it really does sometimes work, I don't know why it sometimes works and most of the time doesn't

Comment 12

[tysingibson514]

other machine:
Arch GNU/Linux
Xorg or X (display server protocol)
dwm (window manager)
firefox 131 - no problem

machine firefox bookmark on buttons not working:
Arch GNU/Linux
wayland (display server protocol)
hyprland (window manager)
firefox 130.0.1 - has problem

both doesn't use desktop environment(eg. gnome, kde, xfce)

Comment 13

[James Teow [:jteow]]

Hi Oriol, based on the steps that Alice provided in Comment 9, are you able to confirm the regression range?

Comment 14

[Oriol Brufau [:Oriol]]

Yes, I confirmed the regression range, but I'm quite sure it wasn't bug 1804247.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 16

[Marco Bonardo [:mak]]

If I just right click (release the button) on the inside folder, and then left click on the context menu, I see no problem. I think this is a most commonly expected behavior.
If I right mousedown on the folder, and release on a context menuitem, it doesn't work. On the first folder on the toolbar (not the inside one) holding down right and releasing on a menuitem works.

I'm not sure if OP is reporting the former to not be working, or effectively just holding down right button and releasing on an option? I cannot reproduce a bug on the most common behavior.

Using Alice's steps I ended up in a different regrange:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=89aa2c8696b7b10a4e71f95d4a468171b92bb828&tochange=cc33400f0ff80f0eada6c3aa637f37d247a3ff46

This regrange includes Bug 1749174 - Consider enabling wayland if available, that makes me suspicious this is just a bug in the Wayland support code. This sounds compatible with comment 11, where things seem to be working fine on X Server.

All considering, I think this is a low priority bug, for which we'd accept a contributed patch.
Though this assumption is based on the fact right click followed by normal left click works for me, and I couldn't reproduce a bug there.