1921705 - `Selection.modify()` from collapsed white-space only text node after `Selection.selectAllChildren(document.querySelector("[contenteditable]"))` causes putting caret into following non-editable text

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

STR

1. Load https://jsfiddle.net/d_toybox/70jse21k/1/
2. See the console

ER

The console shows: "focusNode=#text: \" ;\", anchorNode=#text: \" ;\"". I.e., Selection should be collapsed in the text node after the non-editable <span>.

AR

The console shows: "focusNode=#text: \"not editable\", anchorNode=#text: \"not editable\"", e.g., Selection is collapsed in the text node in the non-editable <span>.

If there is no getSelection().selectAllChildren(editingHost) call, it works. So, it seems that the call causes resetting the ancestor limiter.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay, it seems that selectAllChildren() causes setting caret hint to "after" and that changed the behavior.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1921705 - Make `nsIFrame::PeekOffsetForCharacter` treat non-editable frames as non-selectable r=emilio!,#dom-core

When PeekOffsetForCharacter find a non-editable content, it should never
return the frame because user must want to move caret only in editable content
when the previous position is editable. Additionally, when a non-selectable
frame is skipped, caret will be moved enough, so it should not skip any editable
content. Finally, the found frame may cause a line break. Therefore, this
patch overwrites the result of SelectablePeekReport::PeekOffsetForCharacter
from FOUND to CONTINUE_UNSELECTABLE when non-editable content is found.

The remaining failures of the new WPT should be handled in bug 449685 because
they are caused by no frame for invisible preceding/trailing white spaces around
the block element boundary.

Depends on D223909

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/755750429ced
Make `nsIFrame::PeekOffsetForCharacter` treat non-editable frames as non-selectable r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48440 for changes under testing/web-platform/tests

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/755750429ced

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot