Closed Bug 1921758 Opened 4 months ago Closed 3 months ago

Use aria-pressed for selected breadcrumb item

Categories

(DevTools :: Inspector, task)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(firefox134 fixed)

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1921758 - [devtools] Use aria-pressed for selected breadcrumb item. r=#devtools-reviewers.
48 bytes, text/x-phabricator-request
Details | Review

At the moment, we're only setting a "checked" attribute, which doesn't have any semantics on buttons

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08dc66cce1b1 [devtools] Use aria-pressed for selected breadcrumb item. r=devtools-reviewers,ochameau.

forgot to replace checked attribute with aria-pressed in a few tests, will fix this

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e9948e74a0e [devtools] Use aria-pressed for selected breadcrumb item. r=devtools-reviewers,ochameau.

Backed out for causing dt failures @ browser_inspector_delete-selected-node-02.js.

[task 2024-10-30T08:47:19.357Z] 08:47:19     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | The right node is selected - 
[task 2024-10-30T08:47:19.358Z] 08:47:19     INFO - Buffered messages finished
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:140 - TypeError: can't access property "textContent", breadcrumbs.querySelector(...) is null
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - Stack trace:
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - assertNodeSelectedAndPanelsUpdated@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:140:19
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - async*testManuallyDeleteSelectedNode@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:31:11
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - async*@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:15:9
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - Leaving test bound 
[task 2024-10-30T08:47:19.361Z] 08:47:19     INFO - GECKO(1889) | console.warn: "Async method failed in safeAsyncMethod" (new Error("Connection closed, pending request to server0.conn0.process34//layout56, type getGrids failed\n\nRequest stack:\nrequest@resource://devtools/shared/protocol/Front.js:299:14\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19\ngetAllGrids@resource://devtools/client/fronts/layout.js:173:17\nexports.safeAsyncMethod/<@resource://devtools/shared/async-utils.js:61:25\ngetGrids@resource://devtools/client/inspector/grids/grid-inspector.js:450:35\nasync*onReflow@resource://devtools/client/inspector/grids/grid-inspector.js:544:40\nthrottledFunction@resource://devtools/shared/throttle.js:50:21\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nonReflowInSelection@resource://devtools/client/inspector/inspector.js:1614:10\n_forwardExistingResources@resource://devtools/shared/commands/resource/resource-command.js:1078:13\nwatchResources@resource://devtools/shared/commands/resource/resource-command.js:264:18\nasync*trackReflowsInSelection@resource://devtools/client/inspector/inspector.js:1581:43\nonNewSelection@resource://devtools/client/inspector/inspector.js:1554:10\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nsetNodeFront@resource://devtools/client/framework/selection.js:213:10\n_markContainerAsSelected@resource://devtools/client/inspector/markup/markup.js:2137:32\nnavigate@resource://devtools/client/inspector/markup/markup.js:1471:10\ndeleteNode/</</<@resource://devtools/client/inspector/markup/markup.js:1406:22\n", "resource://devtools/shared/protocol/Front.js", 105))
[task 2024-10-30T08:47:19.363Z] 08:47:19     INFO - GECKO(1889) | console.warn: "Async method failed in safeAsyncMethod" (new Error("Connection closed, pending request to server0.conn0.process34//layout59, type getGrids failed\n\nRequest stack:\nrequest@resource://devtools/shared/protocol/Front.js:299:14\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19\ngetAllGrids@resource://devtools/client/fronts/layout.js:173:17\nexports.safeAsyncMethod/<@resource://devtools/shared/async-utils.js:61:25\ngetGrids@resource://devtools/client/inspector/grids/grid-inspector.js:450:35\nasync*onReflow@resource://devtools/client/inspector/grids/grid-inspector.js:544:40\nthrottledFunction@resource://devtools/shared/throttle.js:50:21\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nonReflowInSelection@resource://devtools/client/inspector/inspector.js:1614:10\n_forwardExistingResources@resource://devtools/shared/commands/resource/resource-command.js:1078:13\nwatchResources@resource://devtools/shared/commands/resource/resource-command.js:264:18\nasync*trackReflowsInSelection@resource://devtools/client/inspector/inspector.js:1581:43\nonNewSelection@resource://devtools/client/inspector/inspector.js:1554:10\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nsetNodeFront@resource://devtools/client/framework/selection.js:213:10\n_markContainerAsSelected@resource://devtools/client/inspector/markup/markup.js:2137:32\nnavigate@resource://devtools/client/inspector/markup/markup.js:1471:10\ndeleteNode/</</<@resource://devtools/client/inspector/markup/markup.js:1406:22\n", "resource://devtools/shared/protocol/Front.js", 105))
[task 2024-10-30T08:47:19.554Z] 08:47:19     INFO - GECKO(1889) | console.warn: "Inspector destroyed while executing onReflow callback"
[task 2024-10-30T08:47:19.555Z] 08:47:19     INFO - Removing tab.
[task 2024-10-30T08:47:19.556Z] 08:47:19     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2024-10-30T08:47:19.577Z] 08:47:19     INFO - Got event: 'TabClose' on [object XULElement].
[task 2024-10-30T08:47:19.613Z] 08:47:19     INFO - Tab removed and finished closing
[task 2024-10-30T08:47:19.628Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.633Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.637Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.638Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.639Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.640Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.641Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.641Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.642Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.643Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.669Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.672Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.675Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.677Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.678Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.680Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.680Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.681Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.681Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.683Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.683Z] 08:47:19     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2024-10-30T08:47:20.000Z] 08:47:20     INFO - GECKO(1889) | MEMORY STAT | vsize 20984532MB | residentFast 1613MB
[task 2024-10-30T08:47:20.002Z] 08:47:20     INFO - TEST-OK | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | took 4936ms
[task 2024-10-30T08:47:20.047Z] 08:47:20     INFO - checking window state
[task 2024-10-30T08:47:20.091Z] 08:47:20     INFO - TEST-START | devtools/client/inspector/test/browser_inspector_delete-selected-node-03.js
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/179b5336ac41 [devtools] Use aria-pressed for selected breadcrumb item. r=devtools-reviewers,ochameau.

https://hg.mozilla.org/mozilla-central/rev/179b5336ac41

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Flags: needinfo?(nchevobbe)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: