1921766 - [css-color] When resolving relative colors there should be no gamut mapping/clipping.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Tiaan Louw]

When converting from an out of gamut origin color, there should be no clipping or mapping. Example:

color(from color(display-p3 1 0 0) srgb r g b) should not resolve to color(srgb 1 0 0), which is clipped. The result should be color(srgb 1.09 -0.22 -0.15).

This should also solve issues will converting to origins and back, e.g. color(from rgb(from color(xyz-d50 0.99 0.88 0.77) r g b) xyz-d50 x y z).

Comment 1

[Daniel Holbert [:dholbert]]

Per extended commit message in https://hg.mozilla.org/mozilla-central/rev/b0ef844bc744 , I believe this bug is responsible for our test failures in https://wpt.fyi/results/css/css-color/parsing/relative-color-out-of-gamut.html?label=experimental&label=master

Comment 2

[Tiaan Louw]

Attachment: Bug 1921766 - Keep colors in non-legacy style before using it as an origin color. r=#layout

When the result of a resolved relative color is in the color(srgb ..)
syntax, make sure not to clamp the components during the calculations.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06c31a8cdcd0
Keep colors in non-legacy style before using it as an origin color. r=layout-reviewers,dshin,emilio

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/06c31a8cdcd0