Closed
Bug 1921767
Opened 4 months ago
Closed 4 months ago
Update wdspec test network/add_intercept/contexts.py to use new context for each test
Categories
(Remote Protocol :: WebDriver BiDi, task, P3)
Remote Protocol
WebDriver BiDi
Tracking
(firefox132 fixed, firefox133 fixed)
RESOLVED
FIXED
133 Branch
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m13])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
We start having relatively frequent intermittents because of remaining requests from previous tests. We should use dedicated contexts for each test to avoid this.
Assignee | ||
Comment 1•4 months ago
|
||
Using a new_tab context for each and every test in the file should avoid side effects between
tests.
Updated•4 months ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d6041f18ea1
[wdspec] Update test network/add_intercept/contexts.py to use new tab for each test r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48408 for changes under testing/web-platform/tests
Comment 4•4 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Upstream PR merged by moz-wptsync-bot
Assignee | ||
Updated•4 months ago
|
Points: --- → 2
Priority: -- → P3
Whiteboard: [webdriver:m13]
Assignee | ||
Comment 6•4 months ago
|
||
Comment on attachment 9428084 [details]
Bug 1921767 - [wdspec] Update test network/add_intercept/contexts.py to use new tab for each test
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Fixes frequent intermittent failures https://bugzilla.mozilla.org/show_bug.cgi?id=1890217
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just a test update
- String changes made/needed:
- Is Android affected?: No
Attachment #9428084 -
Flags: approval-mozilla-beta?
Comment 7•4 months ago
|
||
Comment on attachment 9428084 [details]
Bug 1921767 - [wdspec] Update test network/add_intercept/contexts.py to use new tab for each test
a=test-only
Attachment #9428084 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•4 months ago
|
status-firefox132:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•